Add OpAMP connection settings capability to the example #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 76.11% 75.61% -0.51%
==========================================
Files 24 24
Lines 1834 1923 +89
==========================================
+ Hits 1396 1454 +58
- Misses 326 352 +26
- Partials 112 117 +5
☔ View full report in Codecov by Sentry. |
srikanthccv
reviewed
Jun 25, 2023
tigrannajaryan
force-pushed
the
feature/tigran/democonnsettings
branch
from
54300ea
to
f63265c
Compare
tigrannajaryan
commented
Jun 26, 2023
This change demonstrates OpAMP Connection Setting Offer Flow from OpAMP spec (see https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#opamp-connection-setting-offer-flow) - The example agent and server now use TLS for OpAMP connection. - The server's certificate is signed by a CA authority. The CA authority's certificate is self-generated (can be re-generated using examples/certs/generate.sh). - The server may generate and offer a client-side certificate to the agent. The generated certificate is signed by the same CA. - The client can accept the certificate and use it for future connections. - Server UI now allows the user to generate a certificate to offer to the agent (for the first time or to rotate). The flows are described in the OpAMP spec, see https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#trust-on-first-use WARNING: all included certificate files are examples only and MUST NOT be used in production. How to test: 1. Run the server. 2. Run the agent. 3. Go to http://localhost:4321/ 4. Find the connected agent in the list and click it 5. Scroll down and click "Accept and Offer Client Certificate" button.
tigrannajaryan
force-pushed
the
feature/tigran/democonnsettings
branch
from
f63265c
to
c45862c
Compare
srikanthccv
approved these changes
Jun 27, 2023
|
@andykellr OK to merge this or you would like to review? |
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Jul 6, 2023
open-telemetry#174 enabled TLS on the server and non-TLS connections are no longer accepted. This PR updates the Supervisor to use TLS connection (with InsecureSkipVerify=true flag).
tigrannajaryan
added a commit
that referenced
this pull request
Jul 6, 2023
#174 enabled TLS on the server and non-TLS connections are no longer accepted. This PR updates the Supervisor to use TLS connection (with InsecureSkipVerify=true flag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change demonstrates OpAMP Connection Setting Offer Flow from OpAMP spec (see https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#opamp-connection-setting-offer-flow)
WARNING: all included certificate files are examples only and MUST NOT
be used in production.
How to test: