Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(coverage): Add a test case to cover that command is ignored when AcceptsCommand capability is not set #195

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Aug 20, 2023

No description provided.

@srikanthccv srikanthccv requested a review from a team August 20, 2023 18:15
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 91.42% and project coverage change: -0.51% ⚠️

Comparison is base (efddaa2) 76.11% compared to head (c85262d) 75.61%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   76.11%   75.61%   -0.51%     
==========================================
  Files          24       24              
  Lines        1834     1874      +40     
==========================================
+ Hits         1396     1417      +21     
- Misses        326      340      +14     
- Partials      112      117       +5     
Files Changed Coverage Δ
client/types/callbacks.go 66.66% <ø> (ø)
server/httpconnection.go 33.33% <0.00%> (ø)
client/internal/mockserver.go 82.35% <85.71%> (+0.31%) ⬆️
server/serverimpl.go 58.92% <94.73%> (+0.37%) ⬆️
client/httpclient.go 95.16% <100.00%> (+0.42%) ⬆️
client/internal/clientcommon.go 79.80% <100.00%> (ø)
client/internal/httpsender.go 72.22% <100.00%> (+1.25%) ⬆️
client/internal/receivedprocessor.go 72.60% <100.00%> (-11.69%) ⬇️
server/callbacks.go 68.18% <100.00%> (-4.55%) ⬇️
server/wsconnection.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigrannajaryan
Copy link
Member

@srikanthccv please clarify what the change is. Was the test incorrect or did you just add more cases to it?

@srikanthccv
Copy link
Member Author

Ah, sorry, I added one more case. I was going through the coverage report and noticed that the command ignore part is not covered.

@tigrannajaryan tigrannajaryan changed the title (coverage): Command is ignored when agent does not have AcceptsComman… (coverage): Add a test case to cover that command is ignored when AcceptsCommand capability is not set Sep 14, 2023
@tigrannajaryan tigrannajaryan merged commit 146b792 into open-telemetry:main Sep 14, 2023
4 of 5 checks passed
@srikanthccv srikanthccv deleted the command-test branch September 14, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants