Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sample not works #211

Closed
wants to merge 1 commit into from
Closed

Conversation

JaredTan95
Copy link
Member

fix ui dir cloud not be loaded and certs file path in sample server.

@JaredTan95 JaredTan95 requested a review from a team November 11, 2023 01:48
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Files Coverage Δ
client/httpclient.go 95.31% <100.00%> (+0.57%) ⬆️
client/internal/clientcommon.go 80.47% <100.00%> (+0.67%) ⬆️
client/internal/receivedprocessor.go 72.60% <100.00%> (-11.69%) ⬇️
client/types/callbacks.go 66.66% <ø> (ø)
server/callbacks.go 68.18% <100.00%> (-4.55%) ⬇️
server/wsconnection.go 100.00% <100.00%> (ø)
client/internal/packagessyncer.go 59.25% <0.00%> (ø)
server/serverimpl.go 58.92% <95.00%> (+0.37%) ⬆️
server/httpconnection.go 33.33% <0.00%> (ø)
client/internal/mockserver.go 82.35% <85.71%> (+0.31%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@srikanthccv
Copy link
Member

What was the directory you used to run the example server?

@JaredTan95
Copy link
Member Author

What was the directory you used to run the example server?

Thank you for reminding me that I was in the wrong directory. So, I will close this PR.

@JaredTan95 JaredTan95 closed this Nov 14, 2023
@srikanthccv
Copy link
Member

You can rely on the run-examples target without worrying about directory stuff.

@JaredTan95 JaredTan95 deleted the fix_sampl branch November 16, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants