Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add doc comments to server API #215

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Dec 1, 2023

Add doc comments to server API.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (d4a2cd4) 72.43%.
Report is 30 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing ⚠️
client/internal/httpsender.go 88.00% 2 Missing and 1 partial ⚠️
client/internal/mockserver.go 85.71% 2 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
client/internal/clientcommon.go 90.90% 1 Missing ⚠️
client/internal/packagessyncer.go 0.00% 1 Missing ⚠️
server/serverimpl.go 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   76.11%   72.43%   -3.69%     
==========================================
  Files          24       25       +1     
  Lines        1834     2017     +183     
==========================================
+ Hits         1396     1461      +65     
- Misses        326      446     +120     
+ Partials      112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqixu haoqixu marked this pull request as ready for review December 1, 2023 09:39
@haoqixu haoqixu requested a review from a team December 1, 2023 09:39
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tigrannajaryan tigrannajaryan merged commit fc9dfe6 into open-telemetry:main Dec 1, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants