Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ClientSyncedState docstring with a valid link #285

Merged

Conversation

tpaschalis
Copy link
Member

This section was removed when the StatusReport fields were moved over to AgentToServer on open-telemetry/opamp-spec@bc9c8ba

This PR updates the docstring for a newly added field and links back to the status reporting section of the spec.

Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis tpaschalis requested a review from a team June 10, 2024 08:27
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (dc5742f) to head (e0e0044).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files          25       25           
  Lines        1656     1656           
=======================================
  Hits         1258     1258           
  Misses        291      291           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigrannajaryan tigrannajaryan merged commit 2fa19cf into open-telemetry:main Jun 10, 2024
7 checks passed
@tigrannajaryan
Copy link
Member

Thanks @tpaschalis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants