Allow setting Headers in DownloadableFile message #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
tigrannajaryan
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Thank you @tpaschalis
LGTM. Once merged let's add corresponding implementation in OpAMP Go.
@andykellr I will keep this open for a couple days in case you have any comments.
Yes, I can handle that. |
| @@ -2343,7 +2344,9 @@ should download the file: | |||
| and the file SHOULD be downloaded from the location specified in the | |||
| [download_url](#downloadablefiledownload_url) field of the | |||
| [DownloadableFile](#downloadablefile-message) message. The Agent SHOULD use an | |||
| HTTP GET message to download the file. | |||
| HTTP GET message to download the file. The Agent SHOULD include the HTTP | |||
There was a problem hiding this comment.
Let's mark this addition as [Development]. See how it's done in other places.
There was a problem hiding this comment.
Apologies for missing that 🤦
Done, both in the proto definition, and in specification (both inline to the message and in the separate section).
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
|
@tpaschalis thank you for adding this feature. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
This PR amends the spec and protos to include an optional set of headers in DownloadableFile, to be used in the download GET request to set up auth parameters.
This is only one of the ways we could implement setting authentication paramaters to be used by Agents when downloading packages, but it is consistent with other uses of the headers field and generic enough to cover different use cases so I feel it's worth considering.