Skip to content

Commit

Permalink
[receiver/cloudfoundryreceiver] Delete shardid empty test from stream…
Browse files Browse the repository at this point in the history
… tests (now part of config tests). Fix parameters for test function

Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
  • Loading branch information
jriguera and CemDK committed May 13, 2024
1 parent 225202b commit b63ab5c
Showing 1 changed file with 3 additions and 39 deletions.
42 changes: 3 additions & 39 deletions receiver/cloudfoundryreceiver/stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,49 +40,13 @@ func TestValidStream(t *testing.T) {

envelopeStream, createErr := streamFactory.CreateStream(
innerCtx,
cfg.RLPGateway.ShardID)
cfg.RLPGateway.ShardID,
telemetryTypeMetrics,
)

require.NoError(t, createErr)
require.NotNil(t, envelopeStream)

cancel()
}

// Ensure stream create fails when it should
func TestInvalidStream(t *testing.T) {

factory := NewFactory()
cfg := factory.CreateDefaultConfig().(*Config)

uaa, err := newUAATokenProvider(
zap.NewNop(),
cfg.UAA.LimitedClientConfig,
cfg.UAA.Username,
string(cfg.UAA.Password))

require.NoError(t, err)
require.NotNil(t, uaa)

// Stream create should fail if given empty shard ID
streamFactory, streamErr := newEnvelopeStreamFactory(
context.Background(),
componenttest.NewNopTelemetrySettings(),
uaa,
cfg.RLPGateway.ClientConfig,
componenttest.NewNopHost())

require.NoError(t, streamErr)
require.NotNil(t, streamFactory)

innerCtx, cancel := context.WithCancel(context.Background())

invalidShardID := ""
envelopeStream, createErr := streamFactory.CreateStream(
innerCtx,
invalidShardID)

require.EqualError(t, createErr, "shardID cannot be empty")
require.Nil(t, envelopeStream)

cancel()
}

0 comments on commit b63ab5c

Please sign in to comment.