Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/wavefront] do not skip lifecycle tests #29995

Closed
codeboten opened this issue Dec 17, 2023 · 2 comments · Fixed by #31537
Closed

[receiver/wavefront] do not skip lifecycle tests #29995

codeboten opened this issue Dec 17, 2023 · 2 comments · Fixed by #31537
Labels
good first issue Good for newcomers help wanted Extra attention is needed receiver/wavefront

Comments

@codeboten
Copy link
Contributor

These tests should not be skipped.

          add issue to not skip these

Originally posted by @codeboten in #29982 (comment)
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 17, 2023
@github-actions github-actions bot mentioned this issue Dec 19, 2023
Closed
@ChrsMark ChrsMark mentioned this issue Jan 8, 2024
Closed
@ChrsMark
Copy link
Member

ChrsMark commented Jan 8, 2024

Filed #30325 to fix this.

@Sanket-0510 Sanket-0510 mentioned this issue Mar 3, 2024
Merged
dmitryax added a commit that referenced this issue Mar 6, 2024
@Sanket-0510 @dmitryax
[chore][receiver/wavefront] fixes the skip lifecycle (#31537)
0fb37dc 
**Description:**
The lifecycle-test for the wavefront receiver were getting skip as per
the #29995, this PR closes #29995
now if you run `make generate` then `make -C receiver/wavefrontreceiver
test` the lifecycle tests wont be skipped

---------

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@Sanket-0510 @dmitryax @DougManton
[chore][receiver/wavefront] fixes the skip lifecycle (open-telemetry#…
abf9fe4 
…31537)

**Description:**
The lifecycle-test for the wavefront receiver were getting skip as per
the open-telemetry#29995, this PR closes open-telemetry#29995
now if you run `make generate` then `make -C receiver/wavefrontreceiver
test` the lifecycle tests wont be skipped

---------

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
@Sanket-0510 @dmitryax @XinRanZhAWS
[chore][receiver/wavefront] fixes the skip lifecycle (open-telemetry#…
7dd8538 
…31537)

**Description:**
The lifecycle-test for the wavefront receiver were getting skip as per
the open-telemetry#29995, this PR closes open-telemetry#29995
now if you run `make generate` then `make -C receiver/wavefrontreceiver
test` the lifecycle tests wont be skipped

---------

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed receiver/wavefront
Projects
None yet
Milestone
No milestone
2 participants
@codeboten @ChrsMark