Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] support generating lifecycle test in a better way for components don't support windows(or others) #30691

Closed
fatsheep9146 opened this issue Jan 20, 2024 · 3 comments
Assignees
Labels

Comments

@fatsheep9146
Copy link
Contributor

          > this configuration can also be used to generate the liftcycle test to skip windows when the component does not support windows

My understanding is that we should be testing all components on all OSes giving that we expect proper error messages and the that the collector configuration can be parsed on different platforms. Not testing the lifecycle on such platforms as of recently risks crashes without proper error message and regressions in this regard, see:

Originally posted by @pjanotti in #30640 (comment)

As suggested, mdatagen should generate the lifecycle test, which could check whether the component who don't support windows(or other platforms) could throw expected error, not crash.

@fatsheep9146 fatsheep9146 added the cmd/mdatagen mdatagen command label Jan 20, 2024
Copy link
Contributor

Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@dmitryax
Copy link
Member

Resolved by #30640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants