Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Windows tests disabled due to #11451 #28679

Closed
13 tasks done
pjanotti opened this issue Oct 28, 2023 · 0 comments · Fixed by #29532
Closed
13 tasks done

Re-enable Windows tests disabled due to #11451 #28679

pjanotti opened this issue Oct 28, 2023 · 0 comments · Fixed by #29532
Labels
ci-cd CI, CD, testing, build issues os:windows

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Oct 28, 2023 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Many tests were disabled on Windows due to issue #11451 - this issue tracks re-enabling all these tests.
@pjanotti pjanotti added the needs triage New item requiring triage label Oct 28, 2023
This was referenced Oct 28, 2023
Merged
Merged
@crobert-1 crobert-1 added ci-cd CI, CD, testing, build issues os:windows and removed needs triage New item requiring triage labels Oct 30, 2023
@github-actions github-actions bot mentioned this issue Oct 31, 2023
Closed
mx-psi pushed a commit that referenced this issue Oct 31, 2023
@pjanotti
[chore] [cmd/configschema] Update go-sqlite3 to latest version, per #…
d2c2265 
…19421 (#28680)

**Description:**
Update go-sqlite3 on cmd/configschema (same as #19421) to start
re-enabling tests currently being skipped on Windows, see #28679.

**Link to tracking Issue:**
First part of #28679
Related to #11451

**Testing:**
Local tests of `cmd/configschema`.

**Documentation:**
N/A
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@pjanotti @jmsnll
[chore] [cmd/configschema] Update go-sqlite3 to latest version, per o…
0758ac0 
…pen-telemetry#19421 (open-telemetry#28680)

**Description:**
Update go-sqlite3 on cmd/configschema (same as open-telemetry#19421) to start
re-enabling tests currently being skipped on Windows, see open-telemetry#28679.

**Link to tracking Issue:**
First part of open-telemetry#28679
Related to open-telemetry#11451

**Testing:**
Local tests of `cmd/configschema`.

**Documentation:**
N/A
dmitryax pushed a commit that referenced this issue Nov 15, 2023
@pjanotti
[chore] Remove 'skip' #11451 for tests not in need of fixes (#28682)
0c4c32e 
**Description:**
Part 2 of #28679 these are the tests that can be re-enabled without
requiring any code changes after #28680 is merged.

**Link to tracking Issue:**
Related to #28679
@pjanotti pjanotti mentioned this issue Nov 19, 2023
Merged
mx-psi pushed a commit that referenced this issue Nov 20, 2023
@pjanotti
[chore][cmd/configschema] Fix and re-enable resolver tests on Windows (…
38db557 
…#29343)

**Description:**
Part 3 of #28679 these tests needed some fixes, related to file paths,
to be re-enabled on Windows.

**Link to tracking Issue:**
Related to #28679

**Testing:**
Local test run on Windows for the affected packages.

**Documentation:**
N/A
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@pjanotti @RoryCrispin
[chore] [cmd/configschema] Update go-sqlite3 to latest version, per o…
7d135d0 
…pen-telemetry#19421 (open-telemetry#28680)

**Description:**
Update go-sqlite3 on cmd/configschema (same as open-telemetry#19421) to start
re-enabling tests currently being skipped on Windows, see open-telemetry#28679.

**Link to tracking Issue:**
First part of open-telemetry#28679
Related to open-telemetry#11451

**Testing:**
Local tests of `cmd/configschema`.

**Documentation:**
N/A
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@pjanotti @RoryCrispin
[chore] Remove 'skip' open-telemetry#11451 for tests not in need of f…
46a1cb1 
…ixes (open-telemetry#28682)

**Description:**
Part 2 of open-telemetry#28679 these are the tests that can be re-enabled without
requiring any code changes after open-telemetry#28680 is merged.

**Link to tracking Issue:**
Related to open-telemetry#28679
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@pjanotti @RoryCrispin
[chore][cmd/configschema] Fix and re-enable resolver tests on Windows (…
ea2477f 
…open-telemetry#29343)

**Description:**
Part 3 of open-telemetry#28679 these tests needed some fixes, related to file paths,
to be re-enabled on Windows.

**Link to tracking Issue:**
Related to open-telemetry#28679

**Testing:**
Local test run on Windows for the affected packages.

**Documentation:**
N/A
@pjanotti pjanotti mentioned this issue Nov 26, 2023
Merged
djaglowski pushed a commit that referenced this issue Nov 27, 2023
@pjanotti
[receiver/activedirectoryds] Fix panic on Shutdown without correspond…
de3b9c0 
…ing Start call (#29505)

**Description:**
The `activedirectorydsreceiver` is panicking when Shutdown is called
without a previous call to Start. This can happen when some component
fails to be created or started.

**Link to tracking Issue:**
Required for #28679

**Testing:**
Ran test locally and `Run Windows` on my fork.

**Documentation:**
.chloggen for bug fix.
@pjanotti pjanotti mentioned this issue Nov 28, 2023
Merged
djaglowski pushed a commit that referenced this issue Dec 1, 2023
@pjanotti
[chore][cmd/otelcontribcol] Re-enable exporters and receivers tests o…
5343a85 
…n Windows (#29532)

**Description:**
Last part to re-enable all Windows tests disabled due to issue #11451.

Notes:

* The default test timeout is not enough for the `cmd` GROUP on CI and
it was increased to 1200s just for this group on Windows, the default
stays at 300s (which was also enough for my local run).
* The `fileexporter` life cycle test indicates an issue that shouldn't
affect most usages of the collector: if the same configuration is used
to export multiple signals it opens one file handle for each signal but
just closes the one of them at shutdown (the helper only executes the
shutdown for the one signal). This is an issue for the test because
during cleanup the testing attempts to delete the test folder and there
are still handles open to the file that lives inside it. This shouldn't
be a problem for collector users. That said the exporter should close
all file handles on shutdown. I will take look at what can be done to
correct this behavior.
* Fixed a minor typo on the receivers test that affected many lines.

**Link to tracking Issue:**
Fix #28679 - last part.

**Testing:**
Local run and GH CI on my fork with `Run Windows` label.

**Documentation:**
N/A
@pjanotti pjanotti mentioned this issue Jan 19, 2024
Merged
@fatsheep9146 fatsheep9146 mentioned this issue Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues os:windows
Projects
None yet
Milestone
No milestone
2 participants
@pjanotti @crobert-1