-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
honeycomb: adjust the sample rate using an attribute on the span #1162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 89.80% 89.82% +0.02%
==========================================
Files 274 274
Lines 13475 13486 +11
==========================================
+ Hits 12101 12114 +13
+ Misses 1009 1008 -1
+ Partials 365 364 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@chris-smith-zocdoc please fix the linter issues |
To link the original spec issue: open-telemetry/opentelemetry-specification#570. Many thanks for this! |
Don't bother to add a report unless there has been a coverage change. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Description:
Allows setting Honeycomb's sample rate using an attribute on span.
This allows either a custom processor (my use case) or the application sdks to adjust the sample rate value for honeycomb. Once the sampling otel is finalized this implementation could be adjusted to use that instead of a custom attribute.
Testing:
Added unit test
Documentation:
Updated exporter readme