Add AWS SecretsManager Provider #19341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @mhausenblas |
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 3 seconds (43 minutes 39 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute (1 minute 37 seconds less than main branch avg.) and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 1 minute 27 seconds (34 seconds less than main branch avg.) and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 2 minutes 6 seconds and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
❌ build-and-test workflow has finished in 27 minutes 48 seconds (40 minutes 15 seconds less than main branch avg.) and finished at 9th Mar, 2023. 5 jobs failed.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| unittest-matrix (1.19, connector) | - 🔗 | ✅ 98 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, connector) | - 🔗 | ✅ 98 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, internal) | - 🔗 | ✅ 581 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, internal) | - 🔗 | ✅ 581 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, extension) | - 🔗 | ✅ 538 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, processor) | - 🔗 | ✅ 1546 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, extension) | - 🔗 | ✅ 538 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, processor) | - 🔗 | ✅ 1546 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2580 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, receiver-0) | - 🔗 | ✅ 2580 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, receiver-1) | - 🔗 | ✅ 1940 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1940 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2474 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, other) | - 🔗 | ✅ 4729 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.20, exporter) | - 🔗 | ✅ 2474 ❌ 0 ⏭ 0 🔗 | See Details |
| integration-tests | - 🔗 | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, other) | - 🔗 | ✅ 4729 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
| checks | Porto 🔗 | N/A | See Details |
| lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
| lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
| lint-matrix (processor) | - 🔗 | N/A | See Details |
| lint-matrix (exporter) | - 🔗 | N/A | See Details |
| lint-matrix (extension) | - 🔗 | N/A | See Details |
| lint-matrix (connector) | - 🔗 | N/A | See Details |
| lint-matrix (internal) | - 🔗 | N/A | See Details |
| lint-matrix (other) | Lint 🔗 | N/A | See Details |
| build-examples | - 🔗 | N/A | See Details |
| check-collector-module-version | Check Collector Module Version 🔗 | N/A | See Details |
| check-codeowners | Check Code Owner Existence 🔗 | N/A | See Details |
| unittest (1.20) | - 🔗 | N/A | See Details |
| unittest (1.19) | - 🔗 | N/A | See Details |
| lint | Interpret result 🔗 | N/A | See Details |
| cross-compile | - 🔗 | N/A | See Details |
| windows-msi | - 🔗 | N/A | See Details |
| build-package | - 🔗 | N/A | See Details |
| publish-dev | - 🔗 | N/A | See Details |
| publish-check | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 13 minutes 12 seconds (⚠️ 4 minutes 50 seconds more than main branch avg.) and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 15 minutes 36 seconds and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 18 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
✅ e2e-tests workflow has finished in 14 minutes 41 seconds and finished at 9th Mar, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| kubernetes-test (v1.25.3) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.26.0) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.24.7) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.23.13) | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
|
Thank you for your interest in contributing. Please review our contributing guidelines for new components to ensure that the contribution process is followed. |
|
@Aneurysm9 , I think now it's all following the guidelines, can you please double-check ? |
2 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
No stale please |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Can this be re-opened? |
atoulme
added
Accepted Component
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
atoulme
reviewed
Oct 9, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
crobert-1
added
never stale
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
We still have a conflict on this one. |
|
On it |
|
Conflits resolved and commands applied as suggested |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Need to tidy again - |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Let's go again. |
|
Woops. I pushed the wrong branch. I will push to my fork. |
Merged
|
The work continues in #31123 |
dmitryax
pushed a commit
that referenced
this pull request
Feb 16, 2024
== This is continuation of #19341 == **Description:** Adding AWS SecretsManager Support. To be able to inject secrets via AWS Lambda Layer **Link to tracking Issue:** [19368](#19368) **Testing:** Test fetching via SecretsManager emulating AWS API **Documentation:** README.md --------- Co-authored-by: Luís Duarte <lduarte@luisduarte.net>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
== This is continuation of open-telemetry#19341 == **Description:** Adding AWS SecretsManager Support. To be able to inject secrets via AWS Lambda Layer **Link to tracking Issue:** [19368](open-telemetry#19368) **Testing:** Test fetching via SecretsManager emulating AWS API **Documentation:** README.md --------- Co-authored-by: Luís Duarte <lduarte@luisduarte.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding AWS SecretsManager Support. To be able to inject secrets via AWS Lambda Layer
Link to tracking Issue: 19368
Testing: Test fetching via SecretsManager emulating AWS API
Documentation: ?????