[receiver/pulsar] do not expose method #27029
Conversation
| component: pulsarreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Do not export the function `WithLogsUnmarshalers`, `WithMetricsUnmarshalers`, `WithTracesUnmarshalers` and pass checkapi. |
There was a problem hiding this comment.
This is removing the methods altogether, not just making them private
There was a problem hiding this comment.
Sorry, i wrote an incorrect description, thanks for reviews @codeboten!
sakulali
changed the title
receiver/pulsarreceiver/factory.go
Outdated
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure about this removal. This can be actually used along with TracesUnmarshaler, FactoryOption and others. Let's start with deprecating them and see it people complain. Please create a separate issue for this removal where potential users can comment
There was a problem hiding this comment.
I'm sorry, i made a mistake again and accidentally deleted a feature with FactoryOption. Thanks for reviews and thoughtful suggestion @dmitryax!
| @@ -26,33 +26,6 @@ const ( | |||
| // FactoryOption applies changes to PulsarExporterFactory. | |||
| type FactoryOption func(factory *pulsarReceiverFactory) | |||
There was a problem hiding this comment.
@atoulme, looks like the checkapi tool missed FactoryOption, TracesUnmarshaler, MetricsUnmarshaler and LogsUnmarshaler. Is this expected?
There was a problem hiding this comment.
yes it is. For now, the checkapi tool only checks functions, not types. We can add that next but it's more complicated, as Config structs must be exported.
sakulali
changed the title
atoulme
added
the
ready to merge
**Description:** Do not export functions `WithLogsUnmarshalers`, `WithMetricsUnmarshalers`, `WithTracesUnmarshalers`, add tests for that and pass checkapi **Link to tracking Issue:** open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for pulsarreceiver **Documentation:**
Description:
Do not export functions
WithLogsUnmarshalers,WithMetricsUnmarshalers,WithTracesUnmarshalers, add tests for that and pass checkapiLink to tracking Issue:
#26304
Testing:
go run cmd/checkapi/main.go .
make chlog-validate
go test for pulsarreceiver
Documentation: