[chore][extension/opampextension] Enable goleak check #31175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
requested review from
evan-bradley and
tigrannajaryan
as code owners
crobert-1
changed the title
|
It would also great to enable this on https://github.com/open-telemetry/opamp-go |
evan-bradley
approved these changes
Feb 14, 2024
Apologies for the delay, I've rebased. 👍 |
crobert-1
force-pushed
the
goleak_opampext
branch
from
c5c5a10
to
0f9015d
Compare
atoulme
approved these changes
Mar 1, 2024
|
approved as codeowner and approver. This is ready for merge. |
atoulme
added
the
ready to merge
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…#31175) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This enables the `goleak` check for the opamp extension, to help ensure it's not leaking any goroutines. This is a test only change, a `Shutdown` call was missing. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as the added `goleak` check --------- Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables the
goleakcheck for the opamp extension, to help ensure it's not leaking any goroutines. This is a test only change, aShutdowncall was missing.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as the added
goleakcheck