[exporter/loadbalancing] Fix panic on a sub-exporter shutdown #31456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-load-balancing-exp
branch
3 times, most recently
from
46b1931
to
d21aeb9
Compare
dmitryax
force-pushed
the
fix-load-balancing-exp
branch
from
d21aeb9
to
e2959eb
Compare
atoulme
approved these changes
Feb 28, 2024
dmitryax
force-pushed
the
fix-load-balancing-exp
branch
2 times, most recently
from
dd571b0
to
c582e34
Compare
crobert-1
reviewed
Feb 28, 2024
|
Failing CI/CD test |
crobert-1
approved these changes
Feb 29, 2024
jpkrohling
reviewed
Feb 29, 2024
atoulme
approved these changes
Mar 1, 2024
dmitryax
force-pushed
the
fix-load-balancing-exp
branch
from
c582e34
to
6332e6a
Compare
jpkrohling
reviewed
Mar 4, 2024
| @@ -287,6 +287,58 @@ func TestLogsWithoutTraceID(t *testing.T) { | |||
| assert.Len(t, sink.AllLogs(), 1) | |||
| } | |||
|
|
|||
| // this test validates that exporter is can concurrently change the endpoints while consuming logs. | |||
| func TestConsumeLogs_ConcurrentResolverChange(t *testing.T) { | |||
There was a problem hiding this comment.
This test passes on main as well, it might not trigger the error condition this PR is aiming to fix.
There was a problem hiding this comment.
Not sure how it passed for you. Here is the draft PR with the tests only #31566
There was a problem hiding this comment.
Thank you for the confirmation! Something certainly went wrong when backporting it to main on my side. LGTM!
Fix panic when a sub-exporter is shut down while still handling requests
dmitryax
force-pushed
the
fix-load-balancing-exp
branch
from
6332e6a
to
366b03b
Compare
jpkrohling
approved these changes
Mar 5, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…elemetry#31456) Fix panic when a sub-exporter is shut down while still handling requests. This change wraps exporters with an additional working group to ensure that exporters are shut down only after they finish processing data. Fixes open-telemetry#31410 It has some small related refactoring changes. I can extract them in separate PRs if needed.
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…wn (open-telemetry#31602) This resolves the issues seen in open-telemetry#31410 after merging open-telemetry#31456
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…elemetry#31456) Fix panic when a sub-exporter is shut down while still handling requests. This change wraps exporters with an additional working group to ensure that exporters are shut down only after they finish processing data. Fixes open-telemetry#31410 It has some small related refactoring changes. I can extract them in separate PRs if needed.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…wn (open-telemetry#31602) This resolves the issues seen in open-telemetry#31410 after merging open-telemetry#31456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic when a sub-exporter is shut down while still handling requests. This change wraps exporters with an additional working group to ensure that exporters are shut down only after they finish processing data.
Fixes #31410
It has some small related refactoring changes. I can extract them in separate PRs if needed.