Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] add k8s.container.status_last_terminated_reason resource attribute #31505

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Feb 29, 2024

Description:

Add k8s.container.status_last_terminated_reason resource attribute

Link to tracking Issue:
#31282

Testing:

  • unit tests
    Documentation:
  • generated

@povilasv povilasv marked this pull request as ready for review February 29, 2024 08:19
@povilasv povilasv requested a review from a team February 29, 2024 08:19
@povilasv
Copy link
Contributor Author

povilasv commented Mar 1, 2024

Thanks for review, updated based on the comment :)

@povilasv povilasv requested a review from dmitryax March 1, 2024 09:28
@@ -192,6 +192,11 @@ resource_attributes:
type: string
enabled: true

k8s.container.status.last_terminated_reason:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely be in favor of submitting a PR to get this attribute added to the semantic conventions. I am growing more and more worried about how many resource attributes/metrics we have in our k8s receivers that arent specified.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It shouldn't be a blocker, but we need to submit it make sure it's pushed to the sem conv as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed an issue for it open-telemetry/semantic-conventions#922, will see what folks will say :)

@dmitryax dmitryax merged commit 660c59a into open-telemetry:main Mar 12, 2024
141 of 142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 12, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
… resource attribute (open-telemetry#31505)

**Description:** 
Add k8s.container.status.last_terminated_reason resource attribute

**Link to tracking Issue:** open-telemetry#31282
@povilasv povilasv deleted the main-resource-attribute branch April 15, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants