Promote ConvertBetweenSumAndGaugeMetricContext feature flag to beta #34580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
TylerHelmuth
reviewed
Aug 9, 2024
.chloggen/promote-processor_transform_ConvertBetweenSumAndGaugeMetricContext-to-beta.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…llector-contrib into feature/34567
There was a problem hiding this comment.
@iblancasa can you add a warning log somewhere before parsing that is like "hey these functions will only work with the metrics context now, if your build fails check that".
Maybe in Validate somewhere
|
@TylerHelmuth sure! |
…llector-contrib into feature/34567
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…llector-contrib into feature/34567
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
TylerHelmuth
approved these changes
Aug 15, 2024
|
Is there anything pending from this PR? |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…pen-telemetry#34580) **Description:** promote the `processor.transform.ConvertBetweenSumAndGaugeMetricContext` feature flag from `alpha` to `beta`. **Link to tracking Issue:** open-telemetry#34567 **Testing:** I modified the unit test to check when the feature flag is enabled and disabled. --------- Signed-off-by: Israel Blancas <iblancasa@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: promote the
processor.transform.ConvertBetweenSumAndGaugeMetricContextfeature flag fromalphatobeta.Link to tracking Issue: #34567
Testing: I modified the unit test to check when the feature flag is enabled and disabled.