Update example in readme for convert_sum_to_gauge and convert_gauge_to_sum #35022
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
evan-bradley
added
the
Skip Changelog
|
Thanks! I was just about to create the same PR. 👍 |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…o_sum (open-telemetry#35022) **Description:** The feature gate "processor.transform.ConvertBetweenSumAndGaugeMetricContext" was updated from Alpha to Beta. This means that it is now enabled by default. The example in the readme should match with the default behavior which is that the functions convert_sum_to_gauge and convert_gauge_to_sum must be used on the "metric" context **Link to tracking Issue:** open-telemetry#34567 Maybe the Readme should state clearly in which context the functions can be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The feature gate "processor.transform.ConvertBetweenSumAndGaugeMetricContext" was updated from Alpha to Beta. This means that it is now enabled by default. The example in the readme should match with the default behavior which is that the functions convert_sum_to_gauge and convert_gauge_to_sum must be used on the "metric" context
Link to tracking Issue: #34567
Maybe the Readme should state clearly in which context the functions can be used?