[admin] Add criteria for distributions #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Jul 26, 2023
mx-psi
reviewed
Jul 26, 2023
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
jpkrohling
approved these changes
Jul 26, 2023
jpkrohling
approved these changes
Jul 26, 2023
dmitryax
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Just one comment. Otherwise LGTM. Thank you @TylerHelmuth for putting this together!
dmitryax
reviewed
Jul 31, 2023
distributions/README.md
Outdated
| @@ -2,16 +2,17 @@ | |||
|
|
|||
| Support for a distribution implies all the duties covered by the Approver and Maintainer role requirements. In addition, support means that the Collector SIG is the owner and maintainer of the binaries/images of the different Collector distributions and is responsible for the pipeline that produces those artifacts. | |||
|
|
|||
| The Collector SIG must support at least one distribution that is recommended for production which includes support for Prometheus, Jaeger, Zipkin, and OpenCensus. | |||
There was a problem hiding this comment.
Jaeger and OpenCensus will be deprecated and removed at some point. Will we update this one later or better rephrase it now?
There was a problem hiding this comment.
I say we update it once we aren't being held to that expectation. As far as I am aware we still are. @jpkrohling can you confirm?
There was a problem hiding this comment.
They will be, but they are not yet. I'd keep them here, and remove when time comes.
djaglowski
approved these changes
Aug 2, 2023
evan-bradley
approved these changes
Aug 2, 2023
Aneurysm9
reviewed
Aug 2, 2023
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
djaglowski
approved these changes
Aug 3, 2023
atoulme
approved these changes
Aug 4, 2023
Aneurysm9
approved these changes
Aug 4, 2023
dmitryax
approved these changes
Aug 7, 2023
mx-psi
approved these changes
Aug 7, 2023
evan-bradley
approved these changes
Aug 7, 2023
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the explicit criteria that a distribution must meet in order to be included in this repository.
Works towards #360