[chore] delete code to set a version and date, as it it not used #10715
Conversation
| @@ -123,7 +123,7 @@ configuration is provided, ocb will generate a default Collector. | |||
|
|
|||
| func initConfig(flags *flag.FlagSet) error { | |||
| cfg.Logger.Info("OpenTelemetry Collector Builder", | |||
| zap.String("version", version), zap.String("date", date)) | |||
There was a problem hiding this comment.
I believe it was set by ldflags in goreleaser.yml, which was now moved to opentelemetry-collector-releases. Dealing with issue open-telemetry/opentelemetry-collector-releases#664 now and am trying to narrow down why adding the ldflags back doesn't work, wondering if it has to do with version.go below
There was a problem hiding this comment.
yes, it wasn't used, so it had to go. If it's in usage, let's make sure it has tests and is exercised in this repository, and then it will be maintained and we can use it in the -releases repository. This might deserve its own issue in this repository.
There was a problem hiding this comment.
I wrote some tests for it and opened a PR, happy to open an issue to mirror the one in releases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10715 +/- ##
==========================================
+ Coverage 92.24% 92.28% +0.04%
==========================================
Files 403 403
Lines 18720 18714 -6
==========================================
+ Hits 17268 17271 +3
+ Misses 1097 1088 -9
Partials 355 355 ☔ View full report in Codecov by Sentry. |
…sed (open-telemetry#10715)" This reverts commit b53f57d.
No description provided.