Initial deb and rpm packaging #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 212 212
Lines 15152 15152
=======================================
Hits 13546 13546
Misses 1171 1171
Partials 435 435 Continue to review full report at Codecov.
|
jchengsfx
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
flands
approved these changes
Jul 8, 2020
| - run: | ||
| name: Install fpm and dependencies | ||
| command: | | ||
| sudo apt-get update |
There was a problem hiding this comment.
should an upgrade happen here as well?
There was a problem hiding this comment.
upgrade upgrades other deps, update just refreshes the repositories.
packaging/deb/Dockerfile
Outdated
| @@ -0,0 +1,13 @@ | |||
| FROM debian:9 | |||
|
|
|||
| RUN apt-get update && \ | |||
|
Need to make similar changes according to review in open-telemetry/opentelemetry-collector-contrib#405. |
bogdandrutu
requested changes
Jul 8, 2020
- Uses https://github.com/jordansissel/fpm - Builds simple deb and rpm packages that installs the otelcol binary to `/usr/bin/otelcol` and `examples/otel-local-config.yaml` to `/etc/otel-collector/config.yaml`. - TODO: create systemd service scripts
- Add support for arm64 packages - Move files to internal/buildscripts/packaging/ - Use single Dockerfile for local deb and rpm builds - Explicitly set output dir for packages in circleci
bogdandrutu
approved these changes
Jul 8, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Initial deb and rpm packaging - Uses https://github.com/jordansissel/fpm - Builds simple deb and rpm packages that installs the otelcol binary to `/usr/bin/otelcol` and `examples/otel-local-config.yaml` to `/etc/otel-collector/config.yaml`. - TODO: create systemd service scripts * Packaging updates - Add support for arm64 packages - Move files to internal/buildscripts/packaging/ - Use single Dockerfile for local deb and rpm builds - Explicitly set output dir for packages in circleci
6 tasks
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
deb-packageandrpm-packagetargets to Makefilebinary to
/usr/bin/otelcolandexamples/otel-local-config.yamlto
/etc/otel-collector/config.yaml.Link to tracking Issue:
Testing:
Documentation:
packaging/deb/README.mdandpackaging/rpm/README.md