Migrate Prometheus to the new MetricsExporter interface #1477
Conversation
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 239 239
Lines 16706 16709 +3
=======================================
+ Hits 15190 15193 +3
Misses 1085 1085
Partials 431 431
Continue to review full report at Codecov.
|
| for _, metric := range merged { | ||
| _ = pe.exporter.ExportMetric(ctx, md.Node, md.Resource, metric) | ||
| func (pe *prometheusExporter) ConsumeMetrics(ctx context.Context, md pdata.Metrics) error { | ||
| ocmds := pdatautil.MetricsToMetricsData(md) |
There was a problem hiding this comment.
Out of curiousity: what's the long term plan for this? Having to convert the data as the very first step in the "new" metric exporter is pretty confusing.
There was a problem hiding this comment.
The long term is to change to use the new data directly without oc as intermediate step. Right now focus on changing everything to use the new interfaces so at least we are not everywhere in this transition state and service and config code can be changed to only work with the new interfaces
| merge(merged, metric) | ||
| } | ||
| for _, metric := range merged { | ||
| _ = pe.exporter.ExportMetric(ctx, ocmd.Node, ocmd.Resource, metric) |
There was a problem hiding this comment.
Unrelated to this PR (the old code is the same), but we shouldn't ignore errors.
There was a problem hiding this comment.
You commented before to not do unrelated changes :)
…ry#1477) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…etry#1477) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.35.0 to 1.35.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.35.0...v1.35.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
No description provided.