Migrate zipkin receiver/exporter to the new interfaces #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
nilebox
approved these changes
Aug 4, 2020
| if err != nil { | ||
| return len(td.Spans), consumererror.Permanent(fmt.Errorf("failed to push trace data via Zipkin exporter: %w", err)) | ||
| func (ze *zipkinExporter) PushTraceData(ctx context.Context, td pdata.Traces) (int, error) { | ||
| numSpans := td.SpanCount() |
There was a problem hiding this comment.
nit: should the number of spans be extracted from the OC model (after conversion below), since you iterate over it?
There was a problem hiding this comment.
Will fix when will no longer go to OC then Zipkin. See #1446
Codecov Report
@@ Coverage Diff @@
## master #1484 +/- ##
==========================================
+ Coverage 90.91% 90.95% +0.03%
==========================================
Files 239 239
Lines 16706 16708 +2
==========================================
+ Hits 15188 15196 +8
+ Misses 1086 1083 -3
+ Partials 432 429 -3
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1446