Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logs SeverityNumber publicly available #1496

Conversation

tigrannajaryan
Copy link
Member

It was previously available in internal package only.
Now we have the public alias for it.

This is consistent with how we treat other enums, e.g. SpanKind.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1496 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   91.13%   91.14%   +0.01%     
==========================================
  Files         239      239              
  Lines       16787    16787              
==========================================
+ Hits        15299    15301       +2     
+ Misses       1063     1062       -1     
+ Partials      425      424       -1     
Impacted Files Coverage Δ
consumer/pdata/log.go 100.00% <ø> (ø)
consumer/pdata/generated_log.go 100.00% <100.00%> (ø)
internal/data/testdata/log.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.50% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51395f9...fb33552. Read the comment docs.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/public-severitynumber branch from 1875722 to cc0b9b0 Compare August 5, 2020 15:57
@bogdandrutu bogdandrutu self-assigned this Aug 5, 2020
It was previously available in internal package only.
Now we have the public alias for it.

This is consistent with how we treat other enums, e.g. SpanKind.
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/public-severitynumber branch from cc0b9b0 to fb33552 Compare August 5, 2020 20:52
@bogdandrutu bogdandrutu merged commit 44d010f into open-telemetry:master Aug 6, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/public-severitynumber branch August 10, 2020 14:46
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1496)

Bumps [boto3](https://github.com/boto/boto3) from 1.21.44 to 1.21.46.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.21.44...1.21.46)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants