Add minimal support for array value type #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
+ Coverage 91.97% 92.09% +0.12%
==========================================
Files 254 259 +5
Lines 17286 17516 +230
==========================================
+ Hits 15899 16132 +233
+ Misses 989 984 -5
- Partials 398 400 +2
Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/attr-array
branch
2 times, most recently
from
1d88ecd
to
ff62b3c
Compare
bogdandrutu
reviewed
Aug 11, 2020
| @@ -36,13 +36,13 @@ func (ts TimestampUnixNano) String() string { | |||
| type AttributeValueType int | |||
|
|
|||
| const ( | |||
| AttributeValueNULL = iota | |||
| AttributeValueNULL AttributeValueType = iota | |||
There was a problem hiding this comment.
Why not using "AttributeValueNull" as name? Maybe in a separate PR.
There was a problem hiding this comment.
Do you mean to avoid UPPERCASE?
There was a problem hiding this comment.
It is an exported name used in contrib. I am not sure we want to touch it. Certainly not in this PR, which only adds arrays. Perhaps in a future PR if we want it.
There was a problem hiding this comment.
I would be happy to review a future PR that does this
tigrannajaryan
force-pushed
the
feature/tigran/attr-array
branch
from
ff62b3c
to
d3a22ef
Compare
bogdandrutu
approved these changes
Aug 14, 2020
| @@ -36,13 +36,13 @@ func (ts TimestampUnixNano) String() string { | |||
| type AttributeValueType int | |||
|
|
|||
| const ( | |||
| AttributeValueNULL = iota | |||
| AttributeValueNULL AttributeValueType = iota | |||
There was a problem hiding this comment.
I would be happy to review a future PR that does this
go.sum
Outdated
| @@ -10,6 +10,7 @@ cloud.google.com/go v0.50.0/go.mod h1:r9sluTvynVuxRIOHXQEHMFffphuXHOMZMycpNR5e6T | |||
| cloud.google.com/go v0.51.0/go.mod h1:hWtGJ6gnXH+KgDv+V0zFGDvpi07n3z8ZNj3T1RW0Gcw= | |||
| cloud.google.com/go v0.52.0/go.mod h1:pXajvRH/6o3+F9jDHZWQ5PbGhn+o8w9qiu/CffaVdO4= | |||
| cloud.google.com/go v0.53.0/go.mod h1:fp/UouUEsRkN6ryDKNW/Upv/JBKnv6WDthjR6+vze6M= | |||
| cloud.google.com/go v0.56.0 h1:WRz29PgAsVEyPSDHyk+0fpEkwEFyfhHn+JbksT6gIL4= | |||
There was a problem hiding this comment.
Why all these changes in go.sum?
Array value type was added to AnyValue Protobuf definition but corresponding support in the Collector was missing. This commit adds AnyValueArray internal data type which wraps an a slice of AnyValue pointers. AnyValueArray supports minimal set of functions for now. We will add more functions if needed in the future.
tigrannajaryan
force-pushed
the
feature/tigran/attr-array
branch
from
d3a22ef
to
6ccd8cc
Compare
|
Merging. Contrib-test failure is unrelated is already being fixed in open-telemetry/opentelemetry-collector-contrib#831 |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Bump github.com/apache/thrift to v0.16.0 * Exclude go.opencensus.io v0.19.1
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array value type was added to AnyValue Protobuf definition but corresponding
support in the Collector was missing.
This commit adds AnyValueArray internal data type which wraps an a slice of
AnyValue pointers.
AnyValueArray supports minimal set of functions for now. We will add more
functions if needed in the future.