Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OC to new metrics structure conversion. #1666

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

bogdandrutu
Copy link
Member

Updates #1657

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #1666 into master will increase coverage by 0.10%.
The diff coverage is 92.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   92.09%   92.20%   +0.10%     
==========================================
  Files         263      265       +2     
  Lines       19285    19777     +492     
==========================================
+ Hits        17761    18235     +474     
- Misses       1108     1112       +4     
- Partials      416      430      +14     
Impacted Files Coverage Δ
translator/internaldata/oc_to_old_metrics.go 88.95% <ø> (+0.06%) ⬆️
translator/internaldata/old_metrics_to_oc.go 92.03% <0.00%> (+0.48%) ⬆️
translator/internaldata/metrics_to_oc.go 92.35% <92.35%> (ø)
translator/internaldata/oc_to_metrics.go 93.05% <93.05%> (ø)
internal/data/testdata/metric.go 86.95% <0.00%> (+1.44%) ⬆️
translator/internaldata/resource_to_oc.go 88.88% <0.00%> (+1.85%) ⬆️
internal/data/metrics.go 91.30% <0.00%> (+10.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7fddc...522be36. Read the comment docs.

@bogdandrutu bogdandrutu merged commit fadd7d5 into open-telemetry:master Aug 29, 2020
@bogdandrutu bogdandrutu deleted the newoctometrics branch August 29, 2020 02:50
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants