Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getters for oneof and metricdata types #1675

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Updates #1674

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #1675 into master will increase coverage by 0.01%.
The diff coverage is 75.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files         265      265              
  Lines       19797    19797              
==========================================
+ Hits        18265    18267       +2     
+ Misses       1101     1100       -1     
+ Partials      431      430       -1     
Impacted Files Coverage Δ
internal/data/metrics.go 91.30% <50.00%> (ø)
internal/data/testdata/metric.go 86.95% <62.85%> (ø)
consumer/pdata/metric.go 69.76% <70.37%> (ø)
translator/internaldata/metrics_to_oc.go 92.35% <100.00%> (ø)
translator/internaldata/oc_to_metrics.go 93.05% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.03% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c157903...4da445c. Read the comment docs.

@bogdandrutu bogdandrutu merged commit f9166ee into open-telemetry:master Aug 30, 2020
@bogdandrutu bogdandrutu deleted the renamevals branch August 30, 2020 01:37
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…etry#1675)

Bumps [requests](https://github.com/psf/requests) from 2.27.1 to 2.28.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.27.1...v2.28.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants