-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Receiver: Print a more informative message about 'up' metric value #1826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
- Coverage 91.66% 90.78% -0.88%
==========================================
Files 262 262
Lines 18603 15900 -2703
==========================================
- Hits 17052 14435 -2617
+ Misses 1118 1037 -81
+ Partials 433 428 -5
Continue to review full report at Codecov.
|
@@ -159,14 +156,6 @@ func (tr *transaction) Commit() error { | |||
return err | |||
} | |||
|
|||
if tr.metricBuilder.hasInternalMetric { | |||
m := ochttp.ClientRoundtripLatency.M(tr.metricBuilder.scrapeLatencyMs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed redundant OC metric and related code since it must be registered via OpenCensus view to be used which we don't do in the collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nilebox please fix lint issues. |
@bogdandrutu fixed. |
* Made copy of attribute.KeyValue * Add comments and test * move test to sdk/metric * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Add label order assertions for final results * Update CHANGELOG PR number * Revert code changes and update docs Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Description:
0
separately from other (invalid) values and print informative log message.Link to tracking Issue: Fixes #1825