Regenerate certificates to use SANs instead of Common Name #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <albert.teoh@logz.io>
albertteoh
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
approved these changes
Sep 22, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…#1827) Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.11.1 to 1.11.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.11.1...v1.11.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: albertteoh albert.teoh@logz.io
Description: <Describe what has changed.
Resolves a similar issue to the one discovered in jaegertracing/jaeger#2435, whereby certificates are generated using the Common Name field, instead of SANs.
Link to tracking Issue: #1820
Testing:
Ran
make testafter the changes for both go 1.14.9 and go 1.15.1 to confirm all unit tests are passing.Documentation:
Add comments within the Makefile to describe what the make target does. Additional comments are also included within the
gen-certs.shscript.