Ensure OTLP receiver handles consume errors correctly [OTLP/HTTP] #8038
Conversation
VihasMakwana
changed the title
|
Please add tests and changelog. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8038 +/- ##
==========================================
- Coverage 90.96% 90.81% -0.15%
==========================================
Files 300 300
Lines 15090 15117 +27
==========================================
+ Hits 13726 13729 +3
- Misses 1091 1115 +24
Partials 273 273
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM, but @astencel-sumo might want to take a look as well. We had some discussions about this as part of #7486
|
This PR depends on #8080. Marking as draft for now |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
ping @astencel-sumo |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| permanent bool | ||
| nonPermanent bool |
There was a problem hiding this comment.
It looks like these fields are unused, can they be removed?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: Follow the receiver contract and return 503 for non-permanent and 400 for permanent errors for OTLP/HTTP receiver.
Leave the "Retry-After" field blank and let the client implement an exponential backoff strategy.
Link to tracking Issue: #4335