Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of host metrics disk scraper #921

Merged

Conversation

james-bebbington
Copy link
Member

Link to tracking Issue:
#847

Description:
Added disk scraper to the hostmetricsreceiver which uses gopsutil to collect disk related metrics

image

}

// Close
func (s *Scraper) Close(ctx context.Context) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest to use Shutdown instead of "Close".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright but I'll refactor in another PR again since this is in the Scraper interface

@james-bebbington james-bebbington force-pushed the hostmetrics-disk branch 2 times, most recently from c51a390 to c2d0308 Compare May 7, 2020 01:16
@codecov-io
Copy link

Codecov Report

Merging #921 into master will increase coverage by 0.05%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   85.49%   85.54%   +0.05%     
==========================================
  Files         178      181       +3     
  Lines       13322    13430     +108     
==========================================
+ Hits        11389    11489     +100     
- Misses       1479     1484       +5     
- Partials      454      457       +3     
Impacted Files Coverage Δ
...csreceiver/internal/scraper/diskscraper/factory.go 60.00% <60.00%> (ø)
...eiver/internal/scraper/diskscraper/disk_scraper.go 87.17% <87.17%> (ø)
receiver/hostmetricsreceiver/factory.go 73.07% <100.00%> (+0.52%) ⬆️
...ver/internal/scraper/diskscraper/disk_constants.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 73.52% <0.00%> (-2.95%) ⬇️
service/builder/exporters_builder.go 69.16% <0.00%> (+1.66%) ⬆️
exporter/opencensusexporter/opencensus.go 49.45% <0.00%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0135079...026710b. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1da3156 into open-telemetry:master May 7, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants