Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix currency bug #522

Merged
merged 1 commit into from
Oct 23, 2022
Merged

fix currency bug #522

merged 1 commit into from
Oct 23, 2022

Conversation

cartersocha
Copy link
Contributor

Referencing oscars PR. I'll add a link later

@cartersocha cartersocha requested a review from a team October 23, 2022 03:35
@cartersocha
Copy link
Contributor Author

#507

@austinlparker
Copy link
Member

Testing this out.

austinlparker
austinlparker approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currency values are changing on cart, home, and item detail

@austinlparker austinlparker merged commit cf4bbbf into open-telemetry:main Oct 23, 2022
This was referenced Oct 23, 2022
Closed
Closed
@cartersocha cartersocha deleted the currency_bug branch November 7, 2022 06:49
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@cartersocha
fix currency bug (open-telemetry#522)
f66b77d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinlparker austinlparker austinlparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartersocha @austinlparker