Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change docker compose services to restart unless stopped #690

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Jan 17, 2023

Changes

Per the docker documentation, https://docs.docker.com/config/containers/start-containers-automatically/#use-a-restart-policy a service will start if the docker daemon restarts (or starts, on reboot). It's surprising to have stopped services restart when your PC restarts, and this way seems less surprising.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

per the docker documentation, https://docs.docker.com/config/containers/start-containers-automatically/#use-a-restart-policy a service will start if
the docker daemon restarts (or starts, on reboot). It's surprising to have stopped services restart when your PC restarts, and this way seems
less surprising.
@brettmc brettmc requested a review from a team January 17, 2023 00:42
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit ddd0bc3 into open-telemetry:main Jan 17, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants