Fix python loadgenerator memory leak #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puckpuck please take a look and trying running on your cluster |
cartersocha
changed the title
|
towards: #771 |
|
oooh... this looks super interesting. Will give it a try on a long running tests Wonder if we can do the same for the emailservice now 😛 |
|
I have this running now. Loadgenerator was OOMing every 55-ish hours before. |
julianocosta89
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Image size grew 100MB, but for the benefit that this is bringing I don't have anything against it.
Nice finding @cartersocha!
|
@puckpuck im guessing no news is good news on restarts! Are we good to merge once I resolve the conflicts or have any issues popped up? |
|
I'll confirm tonite one way or the other. |
fatsheep9146
approved these changes
Apr 2, 2023
|
I still see a memory leak, at about the same rate as before :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My good friend ChatGPT and I tried a couple different solutions to eliminate the memory leak here.
The most effective method seemed to be switching to the locustio image as our base image from a generic python option.
I ran both versions locally for ~40 mins. The locustio image stabilized around 67 MB usage. The regular python image continued to add memory usage overtime and was around 86 MB usage when I stopped it.
