-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Fix the solution build in CI to fail if errors are thrown #1487
[repo] Fix the solution build in CI to fail if errors are thrown #1487
Conversation
Assert.Equal(originalParentSpanId, activity.ParentSpanId); | ||
#else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this silently failing up until now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? I tried to look back at the run where it was introduced to see how it got in initially but detailed logging isn't maintained that far back.
The actual code always sets parentSpanId to default so I'm not sure how it ever ended up something other than what the root has.
nt