SqlClient: Provide db.system when creating activity
#1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if this warrants a changelog entry, if so I'll add it. |
Codecov Report
@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 83.76% 83.83% +0.06%
==========================================
Files 192 192
Lines 6165 6172 +7
==========================================
+ Hits 5164 5174 +10
+ Misses 1001 998 -3
|
Yes please as this is an improvement which may be leveraged by end users. |
utpilla
reviewed
Apr 13, 2021
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlActivitySourceHelper.cs
Show resolved
Hide resolved
utpilla
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971, but only for SqlClient (still needed for Redis).