Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stopwatch.StartNew() #2403

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Use Stopwatch.StartNew() #2403

merged 2 commits into from
Sep 22, 2021

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Sep 22, 2021

Use Stopwatch.StartNew(); instead of new Stopwatch(); sw.Start();

This was the only occurrence other than in MetricAPITest.cs which I am working on changing in another branch

@mic-max mic-max requested a review from a team September 22, 2021 19:00
@bruno-garcia
Copy link
Member

This was the only occurrence other than in MetricAPITest.cs which I am working on changing in another branch

Ideally that would land here too and you'd pull main into your branch. So changes stay within their designated PR (i.e: feature not mixed with refactoring)

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2403 (9a9a330) into main (15981df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2403   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files         232      232           
  Lines        7492     7492           
=======================================
  Hits         6010     6010           
  Misses       1482     1482           
Impacted Files Coverage Δ
...Zipkin/Implementation/ZipkinExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 256fc2d into open-telemetry:main Sep 22, 2021
@mic-max mic-max deleted the stopwatch-start-new branch September 22, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants