Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remote IP Address - NULL reference exception #3481

Merged
merged 11 commits into from
Jul 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2022

fix Remote IP Address - NULL reference exception

Fixes #3276.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

fix Remote IP Address - NULL reference exception
@ghost ghost self-requested a review July 24, 2022 12:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@reyang
Copy link
Member

reyang commented Jul 24, 2022

@nayang7 thanks for your contribution! Would you clear the CLA and update the changelog? (and ideally add a test case)

@reyang reyang changed the title Remote IP Address - NULL reference exception - fix issue#3276 (#1) Remote IP Address - NULL reference exception Jul 24, 2022
@reyang reyang changed the title Remote IP Address - NULL reference exception Fix Remote IP Address - NULL reference exception Jul 24, 2022
@ghost
Copy link
Author

ghost commented Jul 26, 2022

@nayang7 thanks for your contribution! Would you clear the CLA and update the changelog? (and ideally add a test case)

@reyang I have updated the changelog and CLA was resolved, btw, I have to say current didn't have test file about '(OpenTelemetry.Instrumentation.AspNetCore/Implementation)/HttpInListener.cs' so it's really hard to test Http here.

nayang7 and others added 2 commits July 26, 2022 10:47
@ghost
Copy link
Author

ghost commented Jul 27, 2022

@reyang hey reyang, it seems 'First-time contributors need a maintainer to approve running workflows.'

@reyang
Copy link
Member

reyang commented Jul 27, 2022

@reyang hey reyang, it seems 'First-time contributors need a maintainer to approve running workflows.'

I just approved the CI workflows.

@ghost
Copy link
Author

ghost commented Jul 27, 2022

@reyang hey reyang, sorry it's my fault, I didn't notice all the format error msg, I just updated fixing 'error SA1513: Closing brace should be followed by blank line'. Thanks your approve again.

@ghost
Copy link
Author

ghost commented Jul 28, 2022

@reyang hey reyang, the format really confused me, need your approval again for 'SA1028 Code Should Not Contain Trailing Whitespaces', thanks.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #3481 (5852406) into main (82e041c) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3481      +/-   ##
==========================================
+ Coverage   86.43%   86.59%   +0.15%     
==========================================
  Files         275      275              
  Lines        9977     9978       +1     
==========================================
+ Hits         8624     8640      +16     
+ Misses       1353     1338      -15     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.74% <100.00%> (+0.06%) ⬆️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 88.88% <0.00%> (-2.23%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 84.11% <0.00%> (+1.86%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 94.50% <0.00%> (+3.29%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+18.18%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+28.57%) ⬆️

@ghost
Copy link
Author

ghost commented Jul 28, 2022

@reyang @cijothomas Just now it seems the checking all passed and with coverage report. Since it lasts several days, just Update branch, then needs approval again. Thanks

@ghost
Copy link
Author

ghost commented Jul 28, 2022

@reyang @cijothomas it seems API Compatibility build-test failed after I update branch

'D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\Common.prod.props(20,5): error MSB3073: The command "powershell -ExecutionPolicy Unrestricted -File "D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\PreBuild.ps1" -package OpenTelemetry -version "1.3.0"" exited with code 1. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry\OpenTelemetry.csproj]
0 Warning(s)
1 Error(s)'

@cijothomas
Copy link
Member

@reyang @cijothomas it seems API Compatibility build-test failed after I update branch

'D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\Common.prod.props(20,5): error MSB3073: The command "powershell -ExecutionPolicy Unrestricted -File "D:\a\opentelemetry-dotnet\opentelemetry-dotnet\build\PreBuild.ps1" -package OpenTelemetry -version "1.3.0"" exited with code 1. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry\OpenTelemetry.csproj] 0 Warning(s) 1 Error(s)'

That is a bit flaky test. However it is not mandatory check, so won't block this PR.
Could you rebase so that we can merge?

@ghost
Copy link
Author

ghost commented Jul 29, 2022

@cijothomas thanks, I have rebased

@cijothomas cijothomas merged commit 0a4a625 into open-telemetry:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote IP Address - NULL reference exception
3 participants