Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Bucket Histogram - part 6 #3494

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 26, 2022

Following #3462.

Changes

  • Minor clean up.
  • Test improvements (which is important for testing positive scales).

@reyang reyang requested a review from a team July 26, 2022 22:44
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #3494 (88fb9cd) into main (6f2b1a0) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3494   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files         270      270           
  Lines        9865     9865           
=======================================
  Hits         8516     8516           
  Misses       1349     1349           
Impacted Files Coverage Δ
src/OpenTelemetry/Internal/MathHelper.cs 90.47% <ø> (+6.03%) ⬆️
...penTelemetry/Metrics/ExponentialBucketHistogram.cs 41.17% <50.00%> (-4.66%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-2.23%) ⬇️
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <0.00%> (+2.53%) ⬆️

@cijothomas cijothomas merged commit 44ac86c into open-telemetry:main Jul 26, 2022
@reyang reyang deleted the reyang/exp-exp branch July 26, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants