Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traces] Support named options in the AddExporter API #3659

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

Applies the named options pattern from #3648 to AddExporter tracer builder extension.

TODOs

  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 13, 2022 22:50
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3659 (a949def) into main (d99307d) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   87.63%   87.82%   +0.18%     
==========================================
  Files         283      283              
  Lines       10264    10264              
==========================================
+ Hits         8995     9014      +19     
+ Misses       1269     1250      -19     
Impacted Files Coverage Δ
...lemetry/Trace/Builder/TracerProviderBuilderBase.cs 91.66% <100.00%> (-0.16%) ⬇️
...y/Trace/Builder/TracerProviderBuilderExtensions.cs 97.67% <100.00%> (+0.11%) ⬆️
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.61% <0.00%> (+0.38%) ⬆️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 96.15% <0.00%> (+4.39%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@CodeBlanch CodeBlanch merged commit 3a8f139 into open-telemetry:main Sep 14, 2022
@CodeBlanch CodeBlanch deleted the tracer-addexporter-namedoptions branch September 14, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants