Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traces] Support named options in gRPC instrumentation #3665

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 14, 2022

Changes

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 14, 2022 23:36
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3665 (2fe8773) into main (928d770) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
- Coverage   87.68%   87.63%   -0.06%     
==========================================
  Files         283      283              
  Lines       10276    10283       +7     
==========================================
  Hits         9011     9011              
- Misses       1265     1272       +7     
Impacted Files Coverage Δ
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.05% <0.00%> (-1.10%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 74.72% <0.00%> (+2.19%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+5.88%) ⬆️

@CodeBlanch CodeBlanch changed the title [Traces] Support named options in gRPCinstrumentation [Traces] Support named options in gRPC instrumentation Sep 14, 2022
@CodeBlanch CodeBlanch merged commit 960908c into open-telemetry:main Sep 15, 2022
@CodeBlanch CodeBlanch deleted the grpc-namedoptions branch September 15, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants