Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logs-branch] Apply Resource dependency injection pattern to LoggerProvider #3813

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 24, 2022

Relates to #3782
Relates to #3798

Changes

Support dependency injection Resource patterns in LoggerProvider.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team October 24, 2022 21:44
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #3813 (962cf1e) into main-logs (aba8a69) will increase coverage by 0.03%.
The diff coverage is 96.87%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           main-logs    #3813      +/-   ##
=============================================
+ Coverage      87.60%   87.64%   +0.03%     
=============================================
  Files            304      304              
  Lines          11476    11496      +20     
=============================================
+ Hits           10054    10076      +22     
+ Misses          1422     1420       -2     
Impacted Files Coverage Δ
src/OpenTelemetry/ProviderExtensions.cs 81.81% <50.00%> (-3.19%) ⬇️
...ryProtocol.Logs/OtlpLogExporterHelperExtensions.cs 71.42% <100.00%> (+10.31%) ⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 94.73% <100.00%> (ø)
...lder/ProviderBuilderServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...Telemetry/Logs/Builder/LoggerProviderBuilderSdk.cs 96.55% <100.00%> (ø)
src/OpenTelemetry/Logs/LoggerProviderSdk.cs 89.01% <100.00%> (+0.37%) ⬆️
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 66.66% <0.00%> (-8.34%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 96.21% <0.00%> (+1.08%) ⬆️
... and 1 more

@alanwest alanwest merged commit 2f4cd5b into open-telemetry:main-logs Oct 24, 2022
@CodeBlanch CodeBlanch deleted the loggerprovider-resource-di branch October 24, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants