Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Define release process for unstable core components #5531

Merged
merged 15 commits into from
Apr 17, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 11, 2024

Closes #5530

Changes

  • Implement release changes for unstable core packages as discussed on the SIG.
  • Fixed package validation not being run for stable instrumentation packages.
  • In publish-packages workflow pass the tag to builds as PackTag and only package projects which match MinVerTagPrefix.
  • Throw build errors if building coreunstable- with rc or stable.
  • Throw build errors if performing package validation without PackageValidationBaselineVersion.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Apr 11, 2024
@CodeBlanch CodeBlanch requested a review from a team April 11, 2024 16:55
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (6250307) to head (949040b).
Report is 180 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5531      +/-   ##
==========================================
+ Coverage   83.38%   85.65%   +2.27%     
==========================================
  Files         297      289       -8     
  Lines       12531    12605      +74     
==========================================
+ Hits        10449    10797     +348     
+ Misses       2082     1808     -274     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.31% <ø> (?)
unittests-Instrumentation-Stable 24.34% <ø> (?)
unittests-Solution-Experimental 85.38% <ø> (?)
unittests-Solution-Stable 85.55% <ø> (?)
unittests-Unstable-Core 19.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

@@ -5,6 +5,16 @@ Only for Maintainers.
1. Decide the tag name (version name) to be released. e.g. 1.4.0-beta.1,
1.0.0-rc9.7 etc.

Notes:

* Instrumentation packages are core unstable packages always depend on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishweshbankwar when can these packages move to contrib repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to move them: #5526. Looking for help.

build/RELEASING.md Outdated Show resolved Hide resolved
build/RELEASING.md Outdated Show resolved Hide resolved
OpenTelemetry.proj Outdated Show resolved Hide resolved
Comment on lines 12 to 13
* `core-`: Core packages. These packages are defined\goverened by the
OpenTelemetry Specification and have released stable versions. They
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this statement true? For example

says it is a core component, it is not defined/governed by the spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed updates to try and make everything clear (and to address the below two comments). Please check it out and LMK what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

build/RELEASING.md Outdated Show resolved Hide resolved
build/RELEASING.md Outdated Show resolved Hide resolved
@CodeBlanch CodeBlanch merged commit 3898df5 into open-telemetry:main Apr 17, 2024
57 checks passed
@CodeBlanch CodeBlanch deleted the repo-release-improvements branch April 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release changes for unstable core components
5 participants