reporter: use semantic convention to report build_id #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-telemetry/semantic-conventions#1329 got merged, which introduces a semantic convention for build_ids. Use this semantic convention in favor of BuildIdKind, that will be dropped with open-telemetry/opentelemetry-proto#584. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
flo-build-id
branch
from
5216a42
to
f3c461c
Compare
christos68k
approved these changes
Sep 12, 2024
Comment on lines
524
to
529
| // AttributeUnits - Optional element we do not use. | ||
| // LinkTable - Optional element we do not use. | ||
| // DropFrames - Optional element we do not use. | ||
| // KeepFrames - Optional element we do not use. | ||
| // TimeNanos - Optional element we do not use. | ||
| // DurationNanos - Optional element we do not use. | ||
| // PeriodType - Optional element we do not use. | ||
| // Period - Optional element we do not use. | ||
| // Comment - Optional element we do not use. | ||
| // DefaultSampleType - Optional element we do not use. |
There was a problem hiding this comment.
I'd also remove all of these, they're just noise.
There was a problem hiding this comment.
No strong feelings here. These comments helped to implement the protocol and to check which fields are implemented and which not. When working on this change, I just noticed, that some of these comments are no longer correct.
fabled
approved these changes
Sep 15, 2024
As there is a higher demand for |
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-telemetry/semantic-conventions#1329 got merged, which introduces a semantic convention for build_ids. Use this semantic convention in favor of BuildIdKind, that will be dropped with open-telemetry/opentelemetry-proto#584.