Move validation of span limits to its own function. #1705

MrAlias · 2021-03-17T16:22:21Z

Lines 183 to 197 in 345f264

    
           if cfg.SpanLimits.EventCountLimit > 0 { 
        
           	c.SpanLimits.EventCountLimit = cfg.SpanLimits.EventCountLimit 
        
           } 
        
           if cfg.SpanLimits.AttributeCountLimit > 0 { 
        
           	c.SpanLimits.AttributeCountLimit = cfg.SpanLimits.AttributeCountLimit 
        
           } 
        
           if cfg.SpanLimits.LinkCountLimit > 0 { 
        
           	c.SpanLimits.LinkCountLimit = cfg.SpanLimits.LinkCountLimit 
        
           } 
        
           if cfg.SpanLimits.AttributePerEventCountLimit > 0 { 
        
           	c.SpanLimits.AttributePerEventCountLimit = cfg.SpanLimits.AttributePerEventCountLimit 
        
           } 
        
           if cfg.SpanLimits.AttributePerLinkCountLimit > 0 { 
        
           	c.SpanLimits.AttributePerLinkCountLimit = cfg.SpanLimits.AttributePerLinkCountLimit 
        
           }

Originally posted by @MrAlias in #1693 (comment)

This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replcae `WithSDK` with `WithSDKOptions`. Resolves open-telemetry#1636, open-telemetry#1705.

This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replaces `WithSDK` with `WithSDKOptions`. Resolves open-telemetry#1636, open-telemetry#1705.

This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replaces `WithSDK` with `WithSDKOptions`. Resolves #1636, #1705.

MrAlias · 2021-03-18T19:08:08Z

resolved in #1693

MrAlias mentioned this issue Mar 17, 2021

sdk/trace: removing ApplyConfig and Config #1693

Merged

MrAlias closed this as completed Mar 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move validation of span limits to its own function. #1705

Move validation of span limits to its own function. #1705

MrAlias commented Mar 17, 2021

MrAlias commented Mar 18, 2021

Move validation of span limits to its own function. #1705

Move validation of span limits to its own function. #1705

Comments

MrAlias commented Mar 17, 2021

MrAlias commented Mar 18, 2021