-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting fails if a 204 No Content is returned #4363
Comments
It is what the OTEL Golang SDK expect :( open-telemetry/opentelemetry-go#4363 Signed-off-by: Goutham <gouthamve@gmail.com>
It is what the OTEL Golang SDK expect :( open-telemetry/opentelemetry-go#4363 Signed-off-by: Goutham <gouthamve@gmail.com>
There is actually a requirement to return a Which I read as: there shouldn't be a 204. But if there's one, we should handle it anyway.
This link isn't about returning NoContent. It's about partial successes (which we do handle), and which still must return a 200. With that said, I agree with you that we should handle NoContent. I've opened a PR for that. |
* Add OTLP Ingestion endpoint We copy files from the otel-collector-contrib. See the README in `storage/remote/otlptranslator/README.md`. This supersedes: #11965 Signed-off-by: gouthamve <gouthamve@gmail.com> * Return a 200 OK It is what the OTEL Golang SDK expect :( open-telemetry/opentelemetry-go#4363 Signed-off-by: Goutham <gouthamve@gmail.com> --------- Signed-off-by: gouthamve <gouthamve@gmail.com> Signed-off-by: Goutham <gouthamve@gmail.com>
Description
The current http exporters expect a http.StatusOK (200) response code. But this is not required by the spec and also not something the collector requires.
Trying to use the exporter in a test fails with:
The text was updated successfully, but these errors were encountered: