Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api/global test flake #907

Closed
jmacd opened this issue Jul 6, 2020 · 4 comments · Fixed by #1829
Closed

Fix api/global test flake #907

jmacd opened this issue Jul 6, 2020 · 4 comments · Fixed by #1829
Assignees
Labels
bug Something isn't working pkg:testing Related to testing or a testing package

Comments

@jmacd
Copy link
Contributor

jmacd commented Jul 6, 2020

--- FAIL: TestHandlerTestSuite (0.03s)
--- FAIL: TestHandlerTestSuite/TestNoDropsOnDelegate (0.02s)
handler_test.go:129:
Error Trace: handler_test.go:129
Error: Received unexpected error:
no errors sent in 10ms
Test: TestHandlerTestSuite/TestNoDropsOnDelegate
Messages: switched to new Handler
FAIL
FAIL go.opentelemetry.io/otel/api/global 0.082s

@MrAlias
Copy link
Contributor

MrAlias commented Jul 7, 2020

I think we may need to bump our CI instance size again. I've noticed that error when I run tests locally limiting to a single core.

Also, I've seen this failure under those conditions as well:

--- FAIL: TestNewExporter_collectorConnectionDiesThenReconnects (0.51s)
    otlp_integration_test.go:349: Round #1: Connected collector: spans: got 0 want 10
FAIL
FAIL	go.opentelemetry.io/otel/exporters/otlp	1.556s
ok  	go.opentelemetry.io/otel/exporters/otlp/internal/transform	1.069s
FAIL
Makefile:96: recipe for target 'test' failed
make: *** [test] Error 1

@MrAlias MrAlias added pkg:testing Related to testing or a testing package bug Something isn't working labels Jul 7, 2020
@MrAlias
Copy link
Contributor

MrAlias commented Jul 7, 2020

also, this

--- FAIL: TestHandlerTestSuite (0.05s)
    --- FAIL: TestHandlerTestSuite/TestNoDropsOnDelegate (0.01s)
        handler_test.go:121: 
            	Error Trace:	handler_test.go:121
            	Error:      	Received unexpected error:
            	            	no errors sent in 10ms
            	Test:       	TestHandlerTestSuite/TestNoDropsOnDelegate
            	Messages:   	starting error stream
FAIL
coverage: 1.5% of statements in ./...
FAIL	go.opentelemetry.io/otel/api/global	0.172s

@MrAlias
Copy link
Contributor

MrAlias commented Jul 7, 2020

Oof, also, this

ok  	go.opentelemetry.io/otel/sdk/metric/controller/pull	1.156s	coverage: 9.4% of statements in ./...
--- FAIL: TestPushExportError (0.01s)
    --- FAIL: TestPushExportError/errNone (0.00s)
        push_test.go:255: 
            	Error Trace:	push_test.go:255
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 0
            	Test:       	TestPushExportError/errNone
FAIL
coverage: 10.0% of statements in ./...
FAIL	go.opentelemetry.io/otel/sdk/metric/controller/push	0.104s

MrAlias referenced this issue in MrAlias/opentelemetry-go Jul 7, 2020
MrAlias added a commit that referenced this issue Jul 7, 2020
@Aneurysm9
Copy link
Member

Would this issue be fixed more durably by using GitHub Actions, as proposed in #880?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:testing Related to testing or a testing package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants