Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kv.Infer to kv.Any #969

Closed
MrAlias opened this issue Jul 24, 2020 · 0 comments · Fixed by #972
Closed

Rename kv.Infer to kv.Any #969

MrAlias opened this issue Jul 24, 2020 · 0 comments · Fixed by #972
Labels
enhancement New feature or request good first issue Good for newcomers pkg:API Related to an API package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 24, 2020

From recent feedback:

Consider renaming Infer to Any. Any is a commonly used concept in Go where type is not known and inferred from an empty interface.

This seems reasonable and in line with common Go naming.
@MrAlias MrAlias added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers pkg:API Related to an API package and removed help wanted Extra attention is needed labels Jul 24, 2020
u5surf added a commit to u5surf/opentelemetry-go that referenced this issue Jul 25, 2020
@u5surf
Rename kv.Infer to kv.Any (open-telemetry#969)
06d13eb 
* Consider renaming Infer to Any. Any is a commonly used concept in Go.
@MrAlias MrAlias linked a pull request Jul 25, 2020 that will close this issue
Rename kv.Infer to kv.Any (#969) #972
Merged
@u5surf u5surf mentioned this issue Jul 25, 2020
Merged
u5surf added a commit to u5surf/opentelemetry-go that referenced this issue Jul 26, 2020
@u5surf
Rename kv.Infer to kv.Any (open-telemetry#969)
9a021b7 
* Consider renaming Infer to Any. Any is a commonly used concept in Go.
MrAlias pushed a commit that referenced this issue Jul 27, 2020
@u5surf
Rename kv.Infer to kv.Any (#969) (#972)
6917167 
* Consider renaming Infer to Any. Any is a commonly used concept in Go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers pkg:API Related to an API package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename kv.Infer to kv.Any (#969) u5surf/opentelemetry-go
1 participant
@MrAlias