Vendor Thrift dependency #1551
Merged
Vendor Thrift dependency #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
approved these changes
Feb 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 127 127
Lines 6599 6597 -2
=======================================
- Hits 5153 5149 -4
- Misses 1201 1203 +2
Partials 245 245
|
MrAlias
approved these changes
Feb 19, 2021
Fixes open-telemetry#1559. Some unit tests were flaking in CI because they expected the timestamp to advance during a test, when it's possible for it to be unchanged instead. This change switches the offending "<" comparisons to "<=".
|
@Aneurysm9 and @MrAlias , thanks for your reviews. I've added these two commits since then in an attempt to address test flakes. There's still some flakiness that isn't covered by those two commits, but please feel free to review them individually. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1548.
Fixes #1559.