Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting-started.md #2644

Closed
wants to merge 5 commits into from
Closed

Update getting-started.md #2644

wants to merge 5 commits into from

Conversation

hong6234
Copy link

@hong6234 hong6234 commented Mar 2, 2022

fix unexpected newline error

@hong6234
Update getting-started.md
061572b 
fix unexpected newline error
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2022 •
edited
Loading

CLA Not Signed

@hanyuancheung hanyuancheung added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 2, 2022
hanyuancheung
hanyuancheung approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@hanyuancheung hanyuancheung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little problem, but add \n looks better. Fix all the same problems. I've helped to fix them all. PTAL

Don't forget to sign the CLA authorization.

Overall lgtm

@MrAlias MrAlias added the blocked:CLA Waiting on CLA to be signed before progress can be made label Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022 •
edited
Loading

Codecov Report

Merging #2644 (bc5c185) into main (0e4c156) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2644   +/-   ##
=====================================
  Coverage   75.7%   75.8%           
=====================================
  Files        173     173           
  Lines      11664   11664           
=====================================
+ Hits        8840    8842    +2     
+ Misses      2614    2612    -2     
  Partials     210     210
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Mar 8, 2022

Can you include a copy of the error? I am not sure what issue this is addressing.

@MrAlias MrAlias added the response needed Waiting on user input before progress can be made label Mar 9, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Mar 15, 2022

Closing as this appears abandoned. Please reopen and address the comments above if this is still being worked on. Thanks!

@MrAlias MrAlias closed this Mar 15, 2022
@hanyuancheung hanyuancheung mentioned this pull request Mar 23, 2022
Closed
@dmathieu dmathieu mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
blocked:CLA Waiting on CLA to be signed before progress can be made response needed Waiting on user input before progress can be made Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hong6234 @MrAlias @hanyuancheung